[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 10 15:35:39 PDT 2020
jingham added a comment.
This looks okay to me though I'm not very familiar with the llvm file system interfaces.
Do we have any tests that tests that log output gets emitted to the file requested when you do "log enable -f somefile whatever"? If so and they still work, LGTM. If we don't test that at all, we should probably add a test on the principle of "when you monkey with something that doesn't have a test, you should add one..."
CHANGES SINCE LAST ACTION
More information about the lldb-commits