[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

This looks reasonable based on my limited knowledge.



================
Comment at: lldb/source/Target/Process.cpp:4671
+             "the expression was running.",
+             thread_id);
+    return eExpressionThreadVanished;
----------------
Is it useful to both log the message and have an almost similarly-worded diagnostic produced in LLVMUserExpression.cpp?

("Yes" is an acceptable answer)


================
Comment at: lldb/source/Target/Process.cpp:5534
+    result_name = "eExpressionThreadVanished";
+  default:
+    result_name = "<unknown>";
----------------
If you remove the default case and initialize the result_name to "
"<unknown>" at the top, you get a free compiler warning every time when someone adds a new enumerator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80350/new/

https://reviews.llvm.org/D80350