[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 21 15:12:13 PDT 2020
aprantl added a comment.
This looks reasonable based on my limited knowledge.
Comment at: lldb/source/Target/Process.cpp:4671
+ "the expression was running.",
+ return eExpressionThreadVanished;
Is it useful to both log the message and have an almost similarly-worded diagnostic produced in LLVMUserExpression.cpp?
("Yes" is an acceptable answer)
Comment at: lldb/source/Target/Process.cpp:5534
+ result_name = "eExpressionThreadVanished";
+ result_name = "<unknown>";
If you remove the default case and initialize the result_name to "
"<unknown>" at the top, you get a free compiler warning every time when someone adds a new enumerator.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits