[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I skimmed it, I guess the one question that comes to mind is how this will behave if we an operating system thread provider plugin active, where it may not actually list all of the threads that exist -- where we try to be tolerant of threads disappearing and then re-appearing later -- and the thread running an inferior function call got scheduled out while the function call was still happening.  Pretty unlikely scenario, but I thought I'd throw it out there.



================
Comment at: lldb/source/Expression/LLVMUserExpression.cpp:235
+          "on which the expression was being run: 0x%" PRIx64
+          " exited during its execution.");
+      return execution_result;
----------------
I think you meant to include the tid in the Printf.  Did this produce a warning?  We should have decorated the Printf() method in this class with the thing that tells clang this is a printf functoin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80350/new/

https://reviews.llvm.org/D80350