[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 21 15:43:54 PDT 2020
jingham marked an inline comment as done.
jingham added inline comments.
Comment at: lldb/source/Target/Process.cpp:4671
+ "the expression was running.",
+ return eExpressionThreadVanished;
> Is it useful to both log the message and have an almost similarly-worded diagnostic produced in LLVMUserExpression.cpp?
> ("Yes" is an acceptable answer)
The diagnostic will go the the user, and end up in the Error in the expression result ValueObject. So that part we have to do. Putting it in the log will make the message show up where it happens in the flow of events we're logging, which is very handy. So IMO it is worthwhile doing the latter as well.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits