[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

LGTM modulo some minor points regarding the test. The refactoring of the parsing code and using `expect_expr` can be done as NFC follow-ups. Thanks for the patch, great work!



================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py:32
+
+        self.runCmd("run", RUN_SUCCEEDED)
+
----------------
All the setup code can just be:
```
        self.build()

        lldbutil.run_to_source_breakpoint(self, '// Set break point at this line.',
                lldb.SBFileSpec("main.cpp", False))
```


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp:3
+#include <stdio.h>
+#include <string.h>
+
----------------
Do we need stdio and string.h?


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp:82
+
+  return 0; //// Set break point at this line.
+}
----------------
`////` instead of `//`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72953/new/

https://reviews.llvm.org/D72953