[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik updated this revision to Diff 239995.
shafik marked an inline comment as done.
shafik added a comment.

- Addressing minor comments
- Adding fix for TestObjCIvarOffsets.py we need to guard `last_field_info.NextBitfieldOffsetIsValid(...)` with a check to make sure we have a bit-field. Objective C treats non-bitfields as all having offset zero.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72953/new/

https://reviews.llvm.org/D72953

Files:
  lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/Makefile
  lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py
  lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72953.239995.patch
Type: text/x-patch
Size: 19397 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200123/259dcb3c/attachment-0001.bin>