[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 10 10:22:17 PST 2020


davide added a comment.

In D72413#1813630 <https://reviews.llvm.org/D72413#1813630>, @teemperor wrote:

> The C++ expression parser will probably behave incredibly incorrectly without a persistent state but before this patch it just crashed, so I think this is good to go.


Should we consider a refactor to `ClangExpressionDeclMap` that makes this more obvious? [and maybe allows us to not sprinkling these checks everywhere] -- as a followup?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72413/new/

https://reviews.llvm.org/D72413





More information about the lldb-commits mailing list