[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

[Frederic Riss via Phabricator via lldb-commits]

friss added a comment.

In D68558#1697890 <https://reviews.llvm.org/D68558#1697890>, @labath wrote:

> I like the idea of passing the variable values "inline". The MAKECMDGOALS thingy seems... clever. I sort of like it, and it also feels like it might be too much.


This is why I didn't commit this without review, I do feel the same.

> do we actually need a functional clean rule? I was under the impression that ever since we moved tests to build out-of-tree the clean rule doesn't do much and isn't even being invoked by default. Should we just delete the clean rules altogether? The handful of tests that actually want to clean and rebuild as a part of the test can do something custom...

Pretty sure the test runs don't need the clean rule, but it's nice to have when manually iterating over the build phase of a test. OTOH, manually doing a "rm -rf" of the build directory is not a big burden.

Anybody else objects to getting rid of the clean rules?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68558/new/

https://reviews.llvm.org/D68558