[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D68558#1698031 <https://reviews.llvm.org/D68558#1698031>, @friss wrote:

> Pretty sure the test runs don't need the clean rule, but it's nice to have when manually iterating over the build phase of a test. OTOH, manually doing a "rm -rf" of the build directory is not a big burden.
>
> Anybody else objects to getting rid of the clean rules?


I like having the clean rule when I'm debugging a particular test and I'm messing with the Makefile. I don't mind having to manually remove the build directory, but it seems like we could just make that the top-level clean rule. If we go that route, let's put in a safeguard so that you don't accidentally remove your current working directory if you forget to pass the `-C` flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68558/new/

https://reviews.llvm.org/D68558