[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

This is some really tricky Make (wow), but I think the benefit of it being so much shorter and localized outweighs the steeper learning curve. Thanks!



================
Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/top-level/Makefile:9
+	$(MAKE) -f $(MAKEFILE_RULES) \
+		CXX_SOURCES=dummy.cpp EXE=dummy $(MAKECMDGOALS)
 
----------------
Can you make sure that this is passing what's necessary by removing the default rule from Makefile.rules that initializes `CC ?=`


================
Comment at: lldb/packages/Python/lldbsuite/test/commands/target/create-deps/Makefile:1
-LIB_PREFIX := load_
-
-LD_EXTRAS := -L. -l$(LIB_PREFIX)a
+LD_EXTRAS := -L. -lload_a
 CXX_SOURCES := main.cpp
----------------
`= -L$(BUILDDIR)` ?
Perhaps `:= -L.` is preferable.


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/namespace_definitions/Makefile:1
 LD_EXTRAS := -L. -l$(LIB_PREFIX)a -l$(LIB_PREFIX)b
 CXX_SOURCES := main.cpp
----------------
Is $(LIBPREFIX) available here? shouldn't this be `=` instead?


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile:1
-LD_EXTRAS = -lobjc -framework Foundation
-
-include Makefile.rules
+LD_EXTRAS = -lobjc -framework Foundation -L. -lTest -lTestExt
+OBJC_SOURCES = main.m
----------------
:= and $(BUILDDIR)


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile:2
+LD_EXTRAS = -lobjc -framework Foundation -L. -lTest -lTestExt
+OBJC_SOURCES = main.m
 
----------------
:=


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile:8
+
+libTest.dylib clean::	Test/Test.m
 	mkdir -p Test
----------------
Let's move these past the `include Makefile.rules` for symmetry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68558/new/

https://reviews.llvm.org/D68558