[Lldb-commits] [lldb] r373016 - [lldb-vscode] correctly handle multiple sourceMap entries

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 26 14:18:38 PDT 2019


Author: xiaobai
Date: Thu Sep 26 14:18:37 2019
New Revision: 373016

URL: http://llvm.org/viewvc/llvm-project?rev=373016&view=rev
Log:
[lldb-vscode] correctly handle multiple sourceMap entries

Summary:
`lldb-vscode` concatenates a string of sourceMap entries
specified in the config, but fails to put a space between
each entry, which causes the settings command to fail.
This patch adds a space between each mapping.

Patch by Richard Howell

Differential Revision: https://reviews.llvm.org/D67569

Modified:
    lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp

Modified: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp?rev=373016&r1=373015&r2=373016&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp (original)
+++ lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp Thu Sep 26 14:18:37 2019
@@ -436,7 +436,7 @@ void SetSourceMapFromArguments(const llv
       }
       auto mapFrom = GetAsString((*mapping)[0]);
       auto mapTo = GetAsString((*mapping)[1]);
-      strm << "\"" << mapFrom << "\" \"" << mapTo << "\"";
+      strm << "\"" << mapFrom << "\" \"" << mapTo << "\" ";
     }
   } else {
     if (ObjectContainsKey(arguments, "sourceMap")) {
@@ -2582,7 +2582,7 @@ const std::map<std::string, RequestCallb
 #undef REQUEST_CALLBACK
   return g_request_handlers;
 }
-  
+
 } // anonymous namespace
 
 int main(int argc, char *argv[]) {




More information about the lldb-commits mailing list