[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

Fri Sep 27 11:56:18 PDT 2019

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1
+MAKE_DSYM := NO
+
----------------
jankratochvil wrote:
> labath wrote:
> > I'm pretty sure this line is not needed.
> Removed in current testsuite: rL373061
So I do not understand how `MAKE_DSYM` works but global removal of `MAKE_DSYM := NO` in rL373061 broke OSX so I have reverted it by rL373110. Keeping `MAKE_DSYM := NO` stays omitted for this testcase.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67589/new/

https://reviews.llvm.org/D67589