[Lldb-commits] [PATCH] D68106: Fix a crasher due to an assert when two files have the same UUID but different paths.

[Greg Clayton via Phabricator via lldb-commits]

clayborg created this revision.
clayborg added reviewers: labath, aadsm, dvlahovski.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
clayborg updated this revision to Diff 222032.
clayborg added a comment.

Remove printf that was left in.


The PlaceholderObjectFile has an assert in SetLoadAddress that fires if "m_base == value" is not true. To avoid this, we create check that the base address matches, and if it doesn't we clear the module that was found using the UUID so that we create a new PlaceholderObjectFile. Added a test to cover this issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68106

Files:
  lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
  lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-same-uuids.yaml
  lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68106.222032.patch
Type: text/x-patch
Size: 12297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190926/242761a5/attachment.bin>