[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

This is awesome, thanks for doing this! I was also thinking about doing something like this at some point as well. :)



================
Comment at: lldb/cmake/modules/AddLLDB.cmake:17
+  if( NOT LTG_SOURCE )
+    message(FATAL_ERROR "SOURCE source-file required by clang_tablegen")
+  endif()
----------------
`clang_tablegen` -> `lldb_tablegen`


================
Comment at: lldb/source/Commands/BreakpointList.td:1
+include "Options.td"
+
----------------
Is BreakpointList.td used? I noticed `hide_aliases` is also implemented in Options.td too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64365/new/

https://reviews.llvm.org/D64365