[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 3 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26
+/// Map of command names to their associated records.
+typedef std::map<std::string, std::vector<Record *>> RecordsByCommand;
+
----------------
labath wrote:
> llvm::StringMap
So the map is also supposed to make sure that our commands in the options file are (deterministically) sorted, so that's why it's just a map. I documented that now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64365/new/

https://reviews.llvm.org/D64365