[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/cmake/modules/AddLLDB.cmake:16
+
+  if( NOT LTG_SOURCE )
+    message(FATAL_ERROR "SOURCE source-file required by clang_tablegen")
----------------
nit: remove the spaces to be consistent. 


================
Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:57
+
+  // If we have any grous, we merge them. Otherwise we move this option into
+  // the all group.
----------------
s/grous/groups/


================
Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:68
+  if (auto R = Option->getValue("Required"))
+    OS << "true";
+  else
----------------
ternary operator?


================
Comment at: lldb/utils/TableGen/LLDBTableGenBackends.h:1
+//===- LLDBTableGenBackends.h - Declarations for LLDB TableGen Backends ---===//
+//
----------------
Use the new license header.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64365/new/

https://reviews.llvm.org/D64365