[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

[António Afonso via Phabricator via lldb-commits]

aadsm marked an inline comment as done.
aadsm added inline comments.


================
Comment at: lldb/source/Host/posix/DomainSocket.cpp:130
+
+std::string DomainSocket::GetSocketName() const {
+  if (m_socket != kInvalidSocketValue) {
----------------
labath wrote:
> This should also be  `GetRemoteSocketName` or something similar (though the word `remote` looks a bit weird when it comes to domain sockets).
uhm.. I'm a bit skeptical on this one 😄 
As far as I understand domain sockets don't really have endpoints, there's just a single point of consumption (the inode). Here's what I see in my head when comparing TCP to Domain sockets:

TCP:
```
consumer o---------o provider
```
Domain:
```
consumer -----o----- provider
```
While on TCP we have 2 things that we can name "remote" and "local". On Domain there's only one thing to name, so I think it would be odd calling it "remote" given there's no parallel with the tcp model.

I don't have strong feelings on this though, and I'm happy to change to land the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62089/new/

https://reviews.llvm.org/D62089