[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

[António Afonso via Phabricator via lldb-commits]

aadsm updated this revision to Diff 200403.
aadsm added a comment.
Herald added subscribers: jfb, mgorny.

- Change GetConnectURI to GetRemoteConnectionURI
- Fixes tests when it comes to using dangling pointers on ConstRefs
- Better usage of the EXPECT_* macros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62089/new/

https://reviews.llvm.org/D62089

Files:
  lldb/include/lldb/Host/Socket.h
  lldb/include/lldb/Host/common/TCPSocket.h
  lldb/include/lldb/Host/common/UDPSocket.h
  lldb/include/lldb/Host/posix/DomainSocket.h
  lldb/source/Host/common/TCPSocket.cpp
  lldb/source/Host/common/UDPSocket.cpp
  lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp
  lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp.rej
  lldb/source/Host/posix/DomainSocket.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  lldb/unittests/Host/CMakeLists.txt
  lldb/unittests/Host/ConnectionFileDescriptorTest.cpp
  lldb/unittests/Host/SocketTest.cpp
  lldb/unittests/Host/SocketTest.cpp.rej
  lldb/unittests/Host/SocketTestUtilities.cpp
  lldb/unittests/Host/SocketTestUtilities.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62089.200403.patch
Type: text/x-patch
Size: 23565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190521/503fb530/attachment-0001.bin>