[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 20 07:10:03 PDT 2019
labath added a comment.
`GetRemoteConnectionURI` sounds fine.
================
Comment at: lldb/source/Host/posix/DomainSocket.cpp:130
+
+std::string DomainSocket::GetSocketName() const {
+ if (m_socket != kInvalidSocketValue) {
----------------
This should also be `GetRemoteSocketName` or something similar (though the word `remote` looks a bit weird when it comes to domain sockets).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62089/new/
https://reviews.llvm.org/D62089
More information about the lldb-commits
mailing list