[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 19 09:17:33 PST 2019


clayborg added inline comments.


================
Comment at: source/Core/Module.cpp:1451-1454
+        // Clear the unwind table too, as that may also be affected by the
+        // symbol file information.
+        m_unwind_table.reset();
+
----------------
Are we sure no one is holding onto info that was given out from an existing UnwindTable? What if we do a backtrace, then load symbol files and then do another backtrace? Seems like we will want to keep our existing info and just call m_unwind_table->Clear()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58347/new/

https://reviews.llvm.org/D58347





More information about the lldb-commits mailing list