[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, jasonmolenda.
Herald added a reviewer: alexshap.
Herald added a subscriber: jdoerfert.

This is a preparatory step to enable adding of unwind plans by symbol
file plugins.

Although at the surface it seems that currently symbol files have
nothing to do with unwinding, this isn't entirely correct even now. The
mere act of adding a symbol file can have the effect of making more
sections (typically .debug_frame) available to the unwinding machinery,
so that it can have more unwind strategies to choose from.

Up until now, we've had a bug, which went largely unnoticed, where
unwind info in the manually added symbols files (target symbols add) was
being ignored during unwinding. Reinitializing the UnwindTable fixes
that bug too.


https://reviews.llvm.org/D58347

Files:
  include/lldb/Core/Module.h
  lit/SymbolFile/Inputs/target-symbols-add-unwind.c
  lit/SymbolFile/target-symbols-add-unwind.test
  source/Core/Module.cpp
  source/Symbol/UnwindTable.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58347.187231.patch
Type: text/x-patch
Size: 4133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190218/887ded05/attachment.bin>