[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda marked an inline comment as done.
jasonmolenda added inline comments.


================
Comment at: source/Core/Module.cpp:1451-1454
+        // Clear the unwind table too, as that may also be affected by the
+        // symbol file information.
+        m_unwind_table.reset();
+
----------------
clayborg wrote:
> Are we sure no one is holding onto info that was given out from an existing UnwindTable? What if we do a backtrace, then load symbol files and then do another backtrace? Seems like we will want to keep our existing info and just call m_unwind_table->Clear()?
I THINK it will be OK.  RegisterContextLLDB holds shared pointers to the UnwindPlans that it got from the UnwindTable, so those will stay alive.  An UnwindPlan doesn't refer back to the UnwindTable it came from.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58347/new/

https://reviews.llvm.org/D58347