[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

JF Bastien via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 8 21:10:13 PST 2019


jfb added a comment.

Do you ever use weak pointers? The single allocation is good until you start holding on to more things (because you can't just keep the block around, you need the entire allocation), so you should make sure you won’t be delaying memory being reclaimed.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990





More information about the lldb-commits mailing list