[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

[Eugene Zelenko via Phabricator via lldb-commits]

Eugene.Zelenko added inline comments.


================
Comment at: lldb/source/API/SBData.cpp:12
+#include <memory>
+
 #include "lldb/API/SBData.h"
----------------
JDevlieghere wrote:
> Eugene.Zelenko wrote:
> > JDevlieghere wrote:
> > > jingham wrote:
> > > > Eugene.Zelenko wrote:
> > > > > Spaces between include statements interfere with Clang-format. Same in other places.
> > > > How?
> > > > 
> > > > We always separate system header includes from lldb includes from llvm includes by putting a blank line.  That's done all over the place in lldb.  I haven't heard of this causing problems before now.  If this does cause problems, that should be fixed in clang-format.  It seems like a really unreasonable requirement.
> > > Indeed, and as far as I know llvm does exactly the same thing. clang-format sorts headers within the same group, which is exactly what we want. 
> > Is there any good reason to be different from LLVM/Clang? Wasn't formatting style was changed in not so recent past to reduce differences?
> > 
> > Examples of problems visible in this patch:
> > 
> > lldb/source/API/SBInstruction.cpp
> > lldb/source/API/SBThread.cpp
> > lldb/source/Commands/CommandObjectMemory.cpp
> > lldb/source/Interpreter/CommandInterpreter.cpp
> I'm saying it's exactly the same in LLDB as it is in LLVM. I'm afraid I don't understand what you mean here.
I don't remember empty lines between headers groups in LLVM and Clang code base.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990