[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Wed Feb 6 04:59:29 PST 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks good to me, but let's wait for zachary too.

In D57809#1386883 <https://reviews.llvm.org/D57809#1386883>, @aleksandr.urakov wrote:

> I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch.

It also has a higher chance of behaving identically on different systems.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57809/new/

https://reviews.llvm.org/D57809