[Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 6 04:47:10 PST 2019


aleksandr.urakov updated this revision to Diff 185526.
aleksandr.urakov added a comment.

I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57809/new/

https://reviews.llvm.org/D57809

Files:
  lit/helper/build.py


Index: lit/helper/build.py
===================================================================
--- lit/helper/build.py
+++ lit/helper/build.py
@@ -566,6 +566,7 @@
         if self.toolchain_type == 'clang-cl':
             args.append('-Xclang')
             args.append('-fkeep-static-consts')
+            args.append('-fms-compatibility-version=19')
         args.append('/c')
 
         args.append('/Fo' + obj)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57809.185526.patch
Type: text/x-patch
Size: 416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190206/17ae5e93/attachment.bin>


More information about the lldb-commits mailing list