[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 25 20:44:01 PST 2019

The idea behind seven is that it’s a place to put stuff that we need for
py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
there’s only one thing there now, but there could be more over time.

At least that was the thinking when I created it.

It seems like there’s two separate issues here: 1) you need to fix a bug,
and 2) you want to propose removing seven. Is it worth doing those two
things separately?
On Fri, Jan 25, 2019 at 6:00 PM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere created this revision.
> JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
> JDevlieghere added a project: LLDB.
> Herald added a reviewer: serge-sans-paille.
> When running the test suite on macOS with Python 3 we noticed a difference
> in behavior between Python 2 and Python 3 for `seven.get_command_output`.
> The output contained a newline with Python 3, but not for Python 2. This
> resulted in an invalid SDK path passed to the compiler.
> There were only two actual usages left of this module so I propose to
> remove it and have a simple, local implementation for `get_command_output`.
> Repository:
> https://reviews.llvm.org/D57275
> Files:
>   packages/Python/lldbsuite/support/seven.py
>   packages/Python/lldbsuite/test/dosep.py
>   packages/Python/lldbsuite/test/dotest.py
>   packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
> packages/Python/lldbsuite/test/functionalities/fat_archives/TestFatArchives.py
>   packages/Python/lldbsuite/test/lang/objc/ivar-IMP/TestObjCiVarIMP.py
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190125/40de9515/attachment.html>

More information about the lldb-commits mailing list