[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
JDevlieghere added a project: LLDB.
Herald added a reviewer: serge-sans-paille.

When running the test suite on macOS with Python 3 we noticed a difference in behavior between Python 2 and Python 3 for `seven.get_command_output`. The output contained a newline with Python 3, but not for Python 2. This resulted in an invalid SDK path passed to the compiler.

There were only two actual usages left of this module so I propose to remove it and have a simple, local implementation for `get_command_output`.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D57275

Files:
  packages/Python/lldbsuite/support/seven.py
  packages/Python/lldbsuite/test/dosep.py
  packages/Python/lldbsuite/test/dotest.py
  packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
  packages/Python/lldbsuite/test/functionalities/fat_archives/TestFatArchives.py
  packages/Python/lldbsuite/test/lang/objc/ivar-IMP/TestObjCiVarIMP.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57275.183674.patch
Type: text/x-patch
Size: 7057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190126/c7fa2880/attachment.bin>