[Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Sat Jan 26 14:18:03 PST 2019

On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> The idea behind seven is that it’s a place to put stuff that we need for
> py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
> there’s only one thing there now, but there could be more over time.
> At least that was the thinking when I created it.

When I was looking at this with Davide yesterday, we were under the
impression that it was an external package (https://pypi.org/project/seven)
or part thereof. Compatibility with Python 2.5 didn't sound particularly
important which is why I wanted to remove it. Anyway, now that I know its
purpose, I'm okay with fixing the newline issue there.

> It seems like there’s two separate issues here: 1) you need to fix a bug,
> and 2) you want to propose removing seven. Is it worth doing those two
> things separately?
> On Fri, Jan 25, 2019 at 6:00 PM Jonas Devlieghere via Phabricator <
> reviews at reviews.llvm.org> wrote:
>> JDevlieghere created this revision.
>> JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
>> JDevlieghere added a project: LLDB.
>> Herald added a reviewer: serge-sans-paille.
>> When running the test suite on macOS with Python 3 we noticed a
>> difference in behavior between Python 2 and Python 3 for
>> `seven.get_command_output`. The output contained a newline with Python 3,
>> but not for Python 2. This resulted in an invalid SDK path passed to the
>> compiler.
>> There were only two actual usages left of this module so I propose to
>> remove it and have a simple, local implementation for `get_command_output`.
>> Repository:
>> https://reviews.llvm.org/D57275
>> Files:
>>   packages/Python/lldbsuite/support/seven.py
>>   packages/Python/lldbsuite/test/dosep.py
>>   packages/Python/lldbsuite/test/dotest.py
>>   packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
>> packages/Python/lldbsuite/test/functionalities/fat_archives/TestFatArchives.py
>>   packages/Python/lldbsuite/test/lang/objc/ivar-IMP/TestObjCiVarIMP.py
>> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190126/e0e3fabb/attachment.html>

More information about the lldb-commits mailing list