[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

[Zachary Turner via lldb-commits]

An unexpected pass won't make the bot red will it?  If so, one option is to
mark them skip, just to make sure we can get the bot turned on as quickly
as possible.

On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova <stilis at microsoft.com>
wrote:

> It’s actually not green – the unexpected passes are counted as a failure.
> With Pavel’s change to add the gcc builder, most of those can now be
> enabled, so I am going to do that today, but there’s still a couple that
> are “unexpectedly passing” when they are in fact failing. We’ll need to fix
> that before making it noisy.
>
>
>
> *From:* Zachary Turner <zturner at google.com>
> *Sent:* Friday, December 14, 2018 10:53 AM
> *To:* reviews+D55575+public+5ea616132429464b at reviews.llvm.org
> *Cc:* pavel at labath.sk; mosescu at google.com; aleksandr.urakov at jetbrains.com;
> amccarth at google.com; clayborg at gmail.com; leonid.mashinskiy at jetbrains.com;
> Stella Stamenova <stilis at microsoft.com>; abidh.haq at gmail.com;
> teemperor at gmail.com; aprantl at apple.com; jdevlieghere at apple.com;
> lldb-commits at lists.llvm.org; llvm at inglorion.net
> *Subject:* Re: [PATCH] D55575: [NativePDB] Support local variables
>
>
>
> I've fixed it.  It looks like the bot should be green again once this test
> starts passing.  Can you make it noisy and starting to send emails now?
>
>
>
> On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner <zturner at google.com>
> wrote:
>
> Ahh, that seems easy enough to fix.  Just need to change the 7 to a
> {{.*}}.  Since we're actually compiling and running a process on the
> buildbot, different versions of Windows will affect this.
>
>
>
> On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> stella.stamenova added a comment.
>
>   $ ":" "RUN: at line 5"
>   $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S"
> "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init"
> "-f"
> "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe"
> "-s"
> "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"
>   $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE"
> "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"
>   # command stderr:
>
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16:
> error: CHECK-NEXT: expected string not found in input
>
>   // CHECK-NEXT: Dumping clang ast for 7 modules.
>
>                  ^
>
>   <stdin>:140:1: note: scanning from here
>
>   Dumping clang ast for 8 modules.
>
>   ^
>
>
>   error: command failed with exit status: 1
>
>
> Repository:
>   rLLDB LLDB
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D55575/new/
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575%2Fnew%2F&data=02%7C01%7CSTILIS%40microsoft.com%7Cf5abc82e04c24d377cb608d661f58443%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804104467065410&sdata=bInnIyIeC7rLfEoq2u2wyQODweSDO1NOMAmCjhYF54A%3D&reserved=0>
>
> https://reviews.llvm.org/D55575
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575&data=02%7C01%7CSTILIS%40microsoft.com%7Cf5abc82e04c24d377cb608d661f58443%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804104467075410&sdata=SJ4TeF000S%2FSwoToY3Tdv375lmUgxDi%2Fe6aDwXIASAI%3D&reserved=0>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181214/8a08bcac/attachment-0001.html>