[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

Fri Dec 14 11:11:11 PST 2018

An unexpected pass makes the bot red. I might un-silence it despite the couple of issues left anyway, but it’s something to be aware of.

Thanks,
-Stella

From: Zachary Turner <zturner at google.com>
Sent: Friday, December 14, 2018 11:04 AM
To: Stella Stamenova <stilis at microsoft.com>
Cc: reviews+D55575+public+5ea616132429464b at reviews.llvm.org; pavel at labath.sk; mosescu at google.com; aleksandr.urakov at jetbrains.com; amccarth at google.com; clayborg at gmail.com; leonid.mashinskiy at jetbrains.com; abidh.haq at gmail.com; teemperor at gmail.com; aprantl at apple.com; jdevlieghere at apple.com; lldb-commits at lists.llvm.org; llvm at inglorion.net
Subject: Re: [PATCH] D55575: [NativePDB] Support local variables

An unexpected pass won't make the bot red will it?  If so, one option is to mark them skip, just to make sure we can get the bot turned on as quickly as possible.

On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova <stilis at microsoft.com<mailto:stilis at microsoft.com>> wrote:
It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing” when they are in fact failing. We’ll need to fix that before making it noisy.

From: Zachary Turner <zturner at google.com<mailto:zturner at google.com>>
Sent: Friday, December 14, 2018 10:53 AM
To: reviews+D55575+public+5ea616132429464b at reviews.llvm.org<mailto:reviews%2BD55575%2Bpublic%2B5ea616132429464b at reviews.llvm.org>
Cc: pavel at labath.sk<mailto:pavel at labath.sk>; mosescu at google.com<mailto:mosescu at google.com>; aleksandr.urakov at jetbrains.com<mailto:aleksandr.urakov at jetbrains.com>; amccarth at google.com<mailto:amccarth at google.com>; clayborg at gmail.com<mailto:clayborg at gmail.com>; leonid.mashinskiy at jetbrains.com<mailto:leonid.mashinskiy at jetbrains.com>; Stella Stamenova <stilis at microsoft.com<mailto:stilis at microsoft.com>>; abidh.haq at gmail.com<mailto:abidh.haq at gmail.com>; teemperor at gmail.com<mailto:teemperor at gmail.com>; aprantl at apple.com<mailto:aprantl at apple.com>; jdevlieghere at apple.com<mailto:jdevlieghere at apple.com>; lldb-commits at lists.llvm.org<mailto:lldb-commits at lists.llvm.org>; llvm at inglorion.net<mailto:llvm at inglorion.net>
Subject: Re: [PATCH] D55575: [NativePDB] Support local variables

I've fixed it.  It looks like the bot should be green again once this test starts passing.  Can you make it noisy and starting to send emails now?

On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner <zturner at google.com<mailto:zturner at google.com>> wrote:
Ahh, that seems easy enough to fix.  Just need to change the 7 to a {{.*}}.  Since we're actually compiling and running a process on the buildbot, different versions of Windows will affect this.

On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
stella.stamenova added a comment.

  $ ":" "RUN: at line 5"
  $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe" "-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"
  $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"
  # command stderr:
  E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input

  // CHECK-NEXT: Dumping clang ast for 7 modules.

                 ^

  <stdin>:140:1: note: scanning from here

  Dumping clang ast for 8 modules.

  ^

  error: command failed with exit status: 1

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55575/new/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575%2Fnew%2F&data=02%7C01%7Cstilis%40microsoft.com%7Ce94403b131ee422adccb08d661f70672%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804110949528178&sdata=GOMvr1K4ZNI8CHL8qckzeqlqv%2BWsB8ryz8iwxeLqxZ0%3D&reserved=0>

https://reviews.llvm.org/D55575<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575&data=02%7C01%7Cstilis%40microsoft.com%7Ce94403b131ee422adccb08d661f70672%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804110949538186&sdata=3OZ6Kr08MiBnVOlM1BFaWCnD9dRB6nJvQ%2FytnH7GkNE%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181214/61b12a3f/attachment.html>