<div dir="ltr">An unexpected pass won't make the bot red will it? If so, one option is to mark them skip, just to make sure we can get the bot turned on as quickly as possible.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova <<a href="mailto:stilis@microsoft.com">stilis@microsoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_6277836100955308932WordSection1">
<p class="MsoNormal">It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing”
when they are in fact failing. We’ll need to fix that before making it noisy.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b>From:</b> Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> <br>
<b>Sent:</b> Friday, December 14, 2018 10:53 AM<br>
<b>To:</b> <a href="mailto:reviews%2BD55575%2Bpublic%2B5ea616132429464b@reviews.llvm.org" target="_blank">reviews+D55575+public+5ea616132429464b@reviews.llvm.org</a><br>
<b>Cc:</b> <a href="mailto:pavel@labath.sk" target="_blank">pavel@labath.sk</a>; <a href="mailto:mosescu@google.com" target="_blank">mosescu@google.com</a>; <a href="mailto:aleksandr.urakov@jetbrains.com" target="_blank">aleksandr.urakov@jetbrains.com</a>; <a href="mailto:amccarth@google.com" target="_blank">amccarth@google.com</a>; <a href="mailto:clayborg@gmail.com" target="_blank">clayborg@gmail.com</a>; <a href="mailto:leonid.mashinskiy@jetbrains.com" target="_blank">leonid.mashinskiy@jetbrains.com</a>; Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank">stilis@microsoft.com</a>>; <a href="mailto:abidh.haq@gmail.com" target="_blank">abidh.haq@gmail.com</a>; <a href="mailto:teemperor@gmail.com" target="_blank">teemperor@gmail.com</a>; <a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>; <a href="mailto:jdevlieghere@apple.com" target="_blank">jdevlieghere@apple.com</a>;
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>; <a href="mailto:llvm@inglorion.net" target="_blank">llvm@inglorion.net</a><br>
<b>Subject:</b> Re: [PATCH] D55575: [NativePDB] Support local variables<u></u><u></u></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_6277836100955308932WordSection1">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">I've fixed it. It looks like the bot should be green again once this test starts passing. Can you make it noisy and starting to send emails now?<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="MsoNormal">Ahh, that seems easy enough to fix. Just need to change the 7 to a {{.*}}. Since we're actually compiling and running a process on the buildbot, different versions of Windows will affect this.<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">stella.stamenova added a comment.<br>
<br>
$ ":" "RUN: at line 5"<br>
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe"
"-s" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"<br>
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" "E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"<br>
# command stderr:<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16: error: CHECK-NEXT: expected string not found in input<br>
<br>
// CHECK-NEXT: Dumping clang ast for 7 modules.<br>
<br>
^<br>
<br>
<stdin>:140:1: note: scanning from here<br>
<br>
Dumping clang ast for 8 modules.<br>
<br>
^<br>
<br>
<br>
error: command failed with exit status: 1<br>
<br>
<br>
Repository:<br>
rLLDB LLDB<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575%2Fnew%2F&data=02%7C01%7CSTILIS%40microsoft.com%7Cf5abc82e04c24d377cb608d661f58443%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804104467065410&sdata=bInnIyIeC7rLfEoq2u2wyQODweSDO1NOMAmCjhYF54A%3D&reserved=0" target="_blank">
https://reviews.llvm.org/D55575/new/</a><br>
<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD55575&data=02%7C01%7CSTILIS%40microsoft.com%7Cf5abc82e04c24d377cb608d661f58443%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636804104467075410&sdata=SJ4TeF000S%2FSwoToY3Tdv375lmUgxDi%2Fe6aDwXIASAI%3D&reserved=0" target="_blank">https://reviews.llvm.org/D55575</a><br>
<br>
<br>
<u></u><u></u></p>
</blockquote>
</div>
</blockquote>
</div>
</div></div></blockquote></div>