[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 2 10:59:53 PDT 2018

jingham added a comment.

The StopOnCrash logic is slightly different.  Because the outer if is "GetStopOnCrash()" you will only set stop on crash if it is set at this level and was set in the previously pushed flag set.  That forces StopOnCrash to be set from the top all the way down.

For StopOnError, the outermost if checks if the option is set, so you will inherit the previous flag set's behavior if the option is unset at this level.

StopOnCrash is used for the --batch mode of the lldb driver, so it has to propagate to any newly sourced sets of commands for it to be useful.  It does need this different kind of setting.


More information about the lldb-commits mailing list