[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 2 11:22:03 PDT 2018

shafik added inline comments.

Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+  const char *k_space_characters = "\t\n\v\f\r ";
+  size_t first_non_space = line.find_first_not_of(k_space_characters);
This looks like duplicate code from from `HandleCommand` I also see that at the the top of the file there is `k_white_space` although I am not sure why it is not in a anonymous namespace and why perhaps it is not a `ConstString`

Comment at: source/Interpreter/CommandInterpreter.cpp:2939
         flags |= eHandleCommandFlagEchoCommand;
+      if (options->m_echo_commands != eLazyBoolNo)
+        flags |= eHandleCommandFlagEchoCommentCommand;
Should this be `m_echo_comment_commands`?


More information about the lldb-commits mailing list