[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added inline comments.


================
Comment at: include/lldb/Interpreter/CommandInterpreter.h:105
 
-  bool GetStopOnError() const { return DefaultToNo(m_stop_on_continue); }
+  bool GetStopOnError() const { return DefaultToNo(m_stop_on_error); }
 
----------------
Unrelated fix


================
Comment at: source/API/SBCommandInterpreter.cpp:81
+}
+
 bool SBCommandInterpreterRunOptions::GetPrintResults() const {
----------------
Added this for symmetry with EchoCommands. Do we actually need it?


================
Comment at: source/Interpreter/CommandInterpreter.cpp:2330
+  eHandleCommandFlagPrintResult = (1u << 4),
+  eHandleCommandFlagStopOnCrash = (1u << 5)
 };
----------------
These values are never stored/serialized right?


================
Comment at: source/Interpreter/CommandInterpreter.cpp:2417
         flags |= eHandleCommandFlagPrintResult;
       }
 
----------------
Could reduce boilerplate in the code above. Just wonder whether there is anything special about `GetStopOnCrash()` or if I could handle it like all the others? Looks no different to `GetStopOnError()`.


https://reviews.llvm.org/D52788