[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

Venkata Ramanaiah via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 4 01:10:54 PDT 2018


ramana-nvr added a reviewer: jingham.
ramana-nvr added a comment.

In https://reviews.llvm.org/D48865#1150995, @jingham wrote:

> check should also use thread->GetID not m_options.m_thread_idx.  This is all error reporting, so it's not a big deal.  But having the error be "failed to resolve line table for frame 5 of thread 4294967295" would be confusing.  Could you change those uses as well?


On the trunk, the error message will be "Failed to resolve the line table for frame 5 of thread index 3", which I think is okay.

Changed couple of others.


https://reviews.llvm.org/D48865





More information about the lldb-commits mailing list