[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 3 10:18:57 PDT 2018


jingham added a comment.

This is correct, thanks for catching it!

There are a few other places that use m_thread_idx above this change.  Everything after the:

  if (thread == nullptr) {

check should also use thread->GetID not m_options.m_thread_idx.  This is all error reporting, so it's not a big deal.  But having the error be "failed to resolve line table for frame 5 of thread 4294967295" would be confusing.  Could you change those uses as well?


https://reviews.llvm.org/D48865





More information about the lldb-commits mailing list