[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added subscribers: zturner, lemo.
lemo added a comment.

Doesn't the LIT based test drop the split-function case (originally
produced with PGO)?

Sorry for being late to the party, but it seems beneficial to have both LIT
*and* checked in binaries since in general they are complementary: checking
against freshly built binaries only covers a matching set of toolchain
components (in particular it's hard to cover the cross-targeting scenarios).

Other than the inconvenience with Phabricator, is there a reason not to
include the original tests as well? The size of the binaries?


https://reviews.llvm.org/D47708