[Lldb-commits] [lldb] r334245 - [lldb-mi] Add overloaded method for setting an error.

Alexander Polyakov via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 7 16:03:49 PDT 2018


Author: apolyakov
Date: Thu Jun  7 16:03:49 2018
New Revision: 334245

URL: http://llvm.org/viewvc/llvm-project?rev=334245&view=rev
Log:
[lldb-mi] Add overloaded method for setting an error.

Reviewers: aprantl, clayborg

Reviewed By: clayborg

Subscribers: ki.stfu, lldb-commits

Differential Revision: https://reviews.llvm.org/D47914

Modified:
    lldb/trunk/tools/lldb-mi/MICmdBase.cpp
    lldb/trunk/tools/lldb-mi/MICmdBase.h

Modified: lldb/trunk/tools/lldb-mi/MICmdBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.cpp?rev=334245&r1=334244&r2=334245&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdBase.cpp Thu Jun  7 16:03:49 2018
@@ -214,6 +214,23 @@ void CMICmdBase::SetError(const CMIUtilS
 
 //++
 //------------------------------------------------------------------------------------
+// Details: Short cut function to enter error information into the command's
+//          metadata object and set the command's error status.
+// Type:    Method.
+// Args:    error - (R) Command result description.
+// Return:  None.
+// Throws:  None.
+//--
+void CMICmdBase::SetError(const lldb::SBError &error) {
+  const char *error_cstr = error.GetCString();
+  if (error_cstr)
+    SetError(error_cstr);
+  else
+    SetError("unknown error");
+}
+
+//++
+//------------------------------------------------------------------------------------
 // Details: Ask a command to provide its unique identifier.
 // Type:    Method.
 // Args:    A unique identifier for this command class.

Modified: lldb/trunk/tools/lldb-mi/MICmdBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.h?rev=334245&r1=334244&r2=334245&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdBase.h Thu Jun  7 16:03:49 2018
@@ -12,6 +12,8 @@
 // C Includes
 // C++ Includes
 // Other libraries and framework includes
+#include "lldb/API/SBError.h"
+
 // Project includes
 #include "MICmdArgSet.h"
 #include "MICmdData.h"
@@ -80,6 +82,7 @@ public:
   // Methods:
 protected:
   void SetError(const CMIUtilString &rErrMsg);
+  void SetError(const lldb::SBError &error);
   template <class T> T *GetOption(const CMIUtilString &vStrOptionName);
   bool ParseValidateCmdOptions();
 




More information about the lldb-commits mailing list