[Lldb-commits] [PATCH] D47889: Use llvm::VersionTuple instead of manual version marshalling

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: zturner, friss, clayborg, jingham.
Herald added a subscriber: emaste.

This has multiple advantages:

- we need only one function argument/instance variable instead of three
- no need to default initialize variables
- no custom parsing code
- VersionTuple has comparison operators, which makes version comparisons much simpler

I think this touches a lot of code which is not very well tested, so I'd
appreciate it if you can double-check the transformations in the code that you
are familiar with.


https://reviews.llvm.org/D47889

Files:
  include/lldb/Core/Module.h
  include/lldb/Host/freebsd/HostInfoFreeBSD.h
  include/lldb/Host/linux/HostInfoLinux.h
  include/lldb/Host/macosx/HostInfoMacOSX.h
  include/lldb/Host/netbsd/HostInfoNetBSD.h
  include/lldb/Host/windows/HostInfoWindows.h
  include/lldb/Interpreter/OptionGroupPlatform.h
  include/lldb/Symbol/ObjectFile.h
  include/lldb/Target/Platform.h
  include/lldb/Target/Process.h
  include/lldb/Utility/Args.h
  source/API/SBModule.cpp
  source/API/SBPlatform.cpp
  source/Core/Module.cpp
  source/Host/freebsd/HostInfoFreeBSD.cpp
  source/Host/linux/HostInfoLinux.cpp
  source/Host/macosx/HostInfoMacOSX.mm
  source/Host/netbsd/HostInfoNetBSD.cpp
  source/Host/windows/HostInfoWindows.cpp
  source/Interpreter/OptionGroupPlatform.cpp
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
  source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  source/Plugins/Platform/Android/PlatformAndroid.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.h
  source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  source/Plugins/Platform/Windows/PlatformWindows.cpp
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  source/Target/Platform.cpp
  source/Utility/Args.cpp
  unittests/Platform/PlatformDarwinTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47889.150347.patch
Type: text/x-patch
Size: 65971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180607/f9ddd065/attachment-0001.bin>