[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

[Davide Italiano via Phabricator via lldb-commits]

davide accepted this revision.
davide added a comment.

LGTM



================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:191-202
+  struct SegmentParsingContext {
+    const EncryptedFileRanges EncryptedRanges;
+    lldb_private::SectionList &UnifiedList;
+    uint32_t NextSegmentIdx = 0;
+    uint32_t NextSectionIdx = 0;
+    bool FileAddressesChanged = false;
+
----------------
clayborg wrote:
> Forward declare this and remove from header file?
Why?


https://reviews.llvm.org/D44074