[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 5 08:34:16 PST 2018

clayborg added inline comments.

Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:202
+          UnifiedList(UnifiedList) {}
+  };
+  void ProcessDysymtabCommand(const llvm::MachO::load_command &load_cmd,
Because it is only used in internal functions... I doesn't have to move, just a suggestion. All this code used to be in the section parsing functions.


More information about the lldb-commits mailing list