[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks fine. Would just move stuff from header into .cpp file for the SegmentParsingContext class. I'll leave that up to you.



================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:191-202
+  struct SegmentParsingContext {
+    const EncryptedFileRanges EncryptedRanges;
+    lldb_private::SectionList &UnifiedList;
+    uint32_t NextSegmentIdx = 0;
+    uint32_t NextSectionIdx = 0;
+    bool FileAddressesChanged = false;
+
----------------
Forward declare this and remove from header file?


https://reviews.llvm.org/D44074