[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

A couple of thoughts come to mind:

- Does this functionality really belong in the client? In case of memory reads, it's the server who patches out the breakpoint opcodes (NativeProcessProtocol::ReadMemoryWithoutTrap). I think it would make sense to do this in the same place. How does gdb handle this?
- Another interesting test would be to read back the memory after writing it and make sure it returns sensible data (interaction with server-side patching).
- As for implementation, wouldn't it be simpler to just disable all breakpoint locations within the range, write the memory, and then re-enable them? I don't expect performance to matter much here.


https://reviews.llvm.org/D39967