[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

This will need a test, preferable covering all of the cases:

- breakpoint right at start with extra data after
- breakpoint right at start with no extra data after
- breakpoint in middle of ranges with data before and after
- breakpoint at end of range with no data after
- multiple breakpoints tests with two breakpoints in a row with no data between with no data before first or after last
- multiple breakpoints tests with two breakpoints in a row with no data between with data before first and after last
- multiple breakpoints tests with two discontiguous breakpoints data between them with data before first and after last

Also, when submitted a diff, please add more context using the -U option:

  % svn diff -x -U99999 ...
  % git diff -U99999 ...

This allows us to see the entire context (I tried to see the context for Process.h, but was unable to see more).


Repository:
  rL LLVM

https://reviews.llvm.org/D39967