[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added a comment.

> Does this functionality really belong in the client? In case of memory reads, it's the server who patches out the breakpoint opcodes (NativeProcessProtocol::ReadMemoryWithoutTrap). I think it would make sense to do this in the same place.

Will not work for gdb-remote mode, other servers treat this just as a block of memory.
I might be wrong, but gdb inserts a breakpoint right before execution of instruction range, containing this breakpoint, and removes right after stop.

What is the need to save breakpoints in general? Because when memory is overwritten, breakpoints may have no sense anymore at their locations...


https://reviews.llvm.org/D39967