[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

Sean Callanan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 16 13:31:04 PDT 2017


spyffe updated this revision to Diff 99186.
spyffe added a comment.

Updated to reflect Pavel Labath's suggestions:

- Used `CFLAGS_NO_DEBUG` where appropriate
- Marked the testcase as having no debug info variants


https://reviews.llvm.org/D33083

Files:
  include/lldb/Symbol/SymbolContext.h
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One.mk
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/One.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/One.h
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One/OneConstant.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/TestConflictingSymbol.py
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two.mk
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/Two.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/Two.h
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two/TwoConstant.c
  packages/Python/lldbsuite/test/lang/c/conflicting-symbol/main.c
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
  source/Symbol/SymbolContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33083.99186.patch
Type: text/x-patch
Size: 21623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170516/b820f14d/attachment-0001.bin>


More information about the lldb-commits mailing list