[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just a few makefile changes where CFLAGS is being modified and this will be good to go. Much better location for this. Sean, please keep an eye out for this kind of thing in the future, I believe there is a lot of type searching code and function searching code that could have the same thing done in the future.



================
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile:6
+
+main.o : CFLAGS += -g -O0
+
----------------
CFLAGS_EXTRAS is the way to add CFLAGS:

```
CFLAGS_EXTRAS += "-g -O0"
```


================
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One.mk:9
+
+CFLAGS += -fPIC
+
----------------
avoid modifying CFLAGS, modify CFLAGS_EXTRAS and then use it if needed


================
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Two.mk:9
+
+CFLAGS += -fPIC
+
----------------
avoid modifying CFLAGS, modify CFLAGS_EXTRAS


https://reviews.llvm.org/D33083