[Lldb-commits] [PATCH] D33083: [Expression parser] Look up module symbols before hunting globally

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One.mk:1
+LEVEL := ../../../make
+
----------------
Thanks for the effort. It almost works for me :), except for the part where you clear out the CFLAGS. We cannot do that, as CFLAGS sometimes contains important flags that we cannot compile without. The "canonical" way to compile without debug info is to use the CFLAGS_NO_DEBUG flag and write the compile rule yourself.

This makefile worked for me, and I hope it will work for you as well as it was pieced together from existing tests:
```
LEVEL := ../../../make

DYLIB_NAME := Two
DYLIB_C_SOURCES := Two/Two.c Two/TwoConstant.c
DYLIB_ONLY := YES

include $(LEVEL)/Makefile.rules

CFLAGS += -fPIC

Two/TwoConstant.o: Two/TwoConstant.c
	$(CC) $(CFLAGS_NO_DEBUG) -c $< -o $@
```


================
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/TestConflictingSymbol.py:16
+
+    mydir = TestBase.compute_mydir(__file__)
+
----------------
Since the test does not depend on debug info, you may want to consider adding
`NO_DEBUG_INFO_TESTCASE = True` here to avoid running it multiple times.


https://reviews.llvm.org/D33083