[Lldb-commits] [PATCH] D31138: Add stub for PluginProcessNetBSD
Kamil Rytarowski via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 21 05:16:13 PDT 2017
krytarowski added a comment.
In https://reviews.llvm.org/D31138#706216, @labath wrote:
> I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).
> Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.
I will go for it. Your idea is good. I originally planned to trim unneeded chunks afterwards, but this direction is cleaner.
More information about the lldb-commits